Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nucleo-F070RB It doesn't work when use internal clock #4390

Merged
merged 2 commits into from
Jun 26, 2017

Conversation

mickeyln
Copy link
Contributor

Description

Nucleo-F070RB have a wrong divisor when it initial the clock.

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Steps to test or reproduce

Run display message to UART

Fixes #4361

@0xc0170
Copy link
Contributor

0xc0170 commented May 25, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented May 25, 2017

@mickeyln can you please sign https://developer.mbed.org/contributor_agreement/ ?

Copy link
Member

@adustm adustm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment to be moved, it is ok. Thank you for your support

@@ -450,7 +450,7 @@ uint8_t SetSysClock_PLL_HSI(void)
RCC_OscInitStruct.LSIState = RCC_LSI_OFF;
RCC_OscInitStruct.PLL.PLLState = RCC_PLL_ON;
RCC_OscInitStruct.PLL.PLLSource = RCC_PLLSOURCE_HSI; // HSI div 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, could you move the comment to the line you modified, please ?
Otherwise looks good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 12, 2017

@mickeyln can you please sign https://developer.mbed.org/contributor_agreement/ ?

Bump, please can you?

@sg- sg- changed the title [Nucleo-F070RB] It doesn't work when use internal clock Nucleo-F070RB It doesn't work when use internal clock Jun 15, 2017
@mickeyln
Copy link
Contributor Author

I had signed the Agreement.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2017

I had signed the Agreement.

What is your nick on developer mbed page? I can't locate mickeyln there.

We would like to progress with this patch

@mickeyln
Copy link
Contributor Author

https://developer.mbed.org/users/MickeyLin/
Is this what you want?

@adbridge
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 626

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants